systeminformation thread not ending: move error handling from utils to app#4160
Merged
Conversation
Collaborator
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
There was a problem hiding this comment.
Looks good! One additional thought: would it make sense to introduce a small dedicated error class (e.g. ConfigError) instead of matching on the "process.exit:1" message string? That might make the intent a bit clearer. No strong opinion though - could also just as well be a follow-up PR.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #4155 because that didn't work when running under electron (
process.on("exit",...)is not called).This approach puts a try/catch around the
startfunction inapp.jsand inutils.jstheprocess.exit(1)calls are replaced withthrow new Error("process.exit:1");. The error messageprocess.exit:1is not evaluated inapp.jsbut needed in the tests.The short delay is now implemented in the catch block so the systeminformation is displayed.